Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r77034759
  
    --- Diff: 
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java ---
    @@ -530,6 +531,9 @@ private void run() {
     
         ProbabilitySampler sampler = new 
ProbabilitySampler(getConfiguration().getFraction(Property.GC_TRACE_PERCENT));
     
    +    // Map of tserver -> timestamp, used by the GCWriteAheadLogs to track 
state of when a tablet server went down
    +    Map<HostAndPort, Long> firstSeenDead = new HashMap<>();
    --- End diff --
    
    Nit: let's make this `final` to make sure that we don't ever accidentally 
overwrite the variable and end up with the same bug in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to