Github user dimaspivak commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76887299
  
    --- Diff: test/pom.xml ---
    @@ -273,5 +275,41 @@
             </dependency>
           </dependencies>
         </profile>
    +    <profile>
    +      <id>minicluster-unit-tests</id>
    +      <properties>
    +        
<accumulo.skipMiniClusterInFailsafe>true</accumulo.skipMiniClusterInFailsafe>
    +      </properties>
    +      <build>
    +        <pluginManagement>
    +          <plugins>
    +            <plugin>
    +              <groupId>org.apache.maven.plugins</groupId>
    +              <artifactId>maven-surefire-plugin</artifactId>
    +              <executions>
    +                <!-- Adds an execution for the minicluster-only tests at 
the test phase -->
    +                <execution>
    +                  <id>run-minicluster-unit-tests</id>
    +                  <goals>
    +                    <goal>test</goal>
    +                  </goals>
    +                  <phase>test</phase>
    +                  <configuration>
    +                    <groups>${accumulo.miniclusterTests}</groups>
    +                    <!-- Includes still limit the search-space for groups 
-->
    +                    <includes>
    +                      <include>**/Test*.java</include>
    +                      <include>**/*Test.java</include>
    +                      <include>**/*TestCase.java</include>
    +                      <include>**/*IT.java</include>
    --- End diff --
    
    Might wanna stick with the Failsafe for ITs, Surefire for unit test 
convention; this gets really confusing with how Maven behaves across the two 
plugins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to