----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51933/#review149122 -----------------------------------------------------------
A couple of extremely minor things. In general, this looks really great. assemble/conf/templates/accumulo-site.xml (line 66) <https://reviews.apache.org/r/51933/#comment216643> I would remove this since it's the default. Users wouldn't have to do set this on their own in most cases. core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java (line 64) <https://reviews.apache.org/r/51933/#comment216642> s/CaffeinatedBlockCacheStatsExecutor/TinyLfuBlockCacheStatsExecutor/ for naming consistency? minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java (line 141) <https://reviews.apache.org/r/51933/#comment216644> Same here, if it's the default, don't need to explicitly set it. - Josh Elser On Sept. 15, 2016, 8:33 p.m., Ben Manes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51933/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 8:33 p.m.) > > > Review request for accumulo, Josh Elser and kturner. > > > Bugs: ACCUMULO-4177 > https://issues.apache.org/jira/browse/ACCUMULO-4177 > > > Repository: accumulo > > > Description > ------- > > TinyLFU-based BlockCache. > > Algorithmic details provided in, > http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html > > > Diffs > ----- > > assemble/conf/templates/accumulo-site.xml eaaf2b6 > core/pom.xml b00a65f > core/src/main/java/org/apache/accumulo/core/conf/Property.java bc1e60e > > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java > 094782d > > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java > 1beaccb > > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java > PRE-CREATION > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java > 5939d2f > pom.xml 2497daa > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > 1523c55 > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java > b3b02ea > > Diff: https://reviews.apache.org/r/51933/diff/ > > > Testing > ------- > > Basic build > > > Thanks, > > Ben Manes > >
