-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/#review149215
-----------------------------------------------------------




core/src/main/java/org/apache/accumulo/core/conf/Property.java (line 246)
<https://reviews.apache.org/r/51933/#comment216771>

    Would be good to document the possible values.



pom.xml (line 167)
<https://reviews.apache.org/r/51933/#comment216769>

    I don't think this new dep will end up in the binary tarball.  I was asking 
Christopher about this offline and he said the following files need to be 
modified for this to happen :
    
      * add dep to assemble/pom.xml
      * add dep to assemble/src/main/assemblies/component.xml


I think these changes look good.

- kturner


On Sept. 16, 2016, 1:15 a.m., Ben Manes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51933/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 1:15 a.m.)
> 
> 
> Review request for accumulo, Josh Elser and kturner.
> 
> 
> Bugs: ACCUMULO-4177
>     https://issues.apache.org/jira/browse/ACCUMULO-4177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> TinyLFU-based BlockCache.
> 
> Algorithmic details provided in,
> http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 44afddb 
>   core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java 
> 4dfba68 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ede1c6f 
>   
> core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java
>  094782d 
>   
> core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java
>  1beaccb 
>   
> core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java
>  PRE-CREATION 
>   
> minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
>  8e35705 
>   pom.xml 54e4a72 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 
> 7751681 
>   
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
>  089bd12 
> 
> Diff: https://reviews.apache.org/r/51933/diff/
> 
> 
> Testing
> -------
> 
> Basic build
> 
> 
> Thanks,
> 
> Ben Manes
> 
>

Reply via email to