Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/220#discussion_r102805336
  
    --- Diff: 
server/master/src/main/java/org/apache/accumulo/master/metrics/Metrics2ReplicationMetrics.java
 ---
    @@ -58,6 +59,7 @@ protected void snapshot() {
         registry.add(PENDING_FILES, getNumFilesPendingReplication());
         registry.add(NUM_PEERS, getNumConfiguredPeers());
         registry.add(MAX_REPLICATION_THREADS, getMaxReplicationThreads());
    +    registry.add(LATENCY, getLatencyInSeconds());
    --- End diff --
    
    Also, now that I think of this, "latency" is not the right word to use. 
Replication latency should be the time in which some record (maybe file, for 
simplicity) was created to when it was replicated. The "latency" which you have 
here is not that -- it's the current maximum time from WAL creation to being 
the replication record being cleaned up. This maximum value includes time for 
Accumulo to clean up the record as well as the time when a WAL was created 
before it received any data for a table being replicated -- it's an 
over-estimation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to