Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/220#discussion_r102778787
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
---
@@ -197,6 +200,7 @@ protected long removeRowIfNecessary(BatchWriter bw,
SortedMap<Key,Value> columns
mutations.add(m);
for (Entry<String,Long> entry : tableToTimeCreated.entrySet()) {
log.info("Removing order mutation for table {} at {} for {}",
entry.getKey(), entry.getValue(), row.toString());
+ collectLatency(entry.getValue());
--- End diff --
Building on the point above: you would want to collect the latencies of
each outstanding file to be replicated, likely not within the execution path of
the Replication internals (metrics should not affect the latency of the system).
It would be better to pull this logic out of `RCRR`, and add it into the
Metrics2ReplicationMetrics, enumerating the files and computing the histogram
of metrics during the metrics collection cycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
