[ https://issues.apache.org/jira/browse/AMQNET-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643365#comment-13643365 ]
Daniel Marbach commented on AMQNET-433: --------------------------------------- Thank you! I must say I have some issues with your formulated answer. I don't see why you consider improving the product as a waste of time. But certainly I can also go through the code and do it if your time is so precious! > Correctly rethrow exceptions without swallowing the stack trace > --------------------------------------------------------------- > > Key: AMQNET-433 > URL: https://issues.apache.org/jira/browse/AMQNET-433 > Project: ActiveMQ .Net > Issue Type: Bug > Components: ActiveMQ > Reporter: Daniel Marbach > Assignee: Jim Gomes > Priority: Trivial > Fix For: 1.6.0 > > > When looking through the code I saw a lot of the following code snippets: > try > { > } > catch(AnyException ex) > { > // do something > throw ex; > } > This WILL rewrite the stack trace and is not considered best practice. I > suggest you change the appropriate places in the code to: > try > { > } > catch(AnyException ex) > { > // do something > throw; > } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira