[
https://issues.apache.org/jira/browse/AMQNET-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643394#comment-13643394
]
Jim Gomes commented on AMQNET-433:
----------------------------------
Daniel, any additional patch contributions are welcome. Tim is working on some
areas of the code that can have a direct and substantial impact on the overall
performance, which makes them a high priority. This item is marked as Trivial
priority, so spending a lot of time searching for edge cases can definitely
seem like a waste of time. I did a quick scan through the code using some
regular expression searching, and it looks like Tim caught most (if not all) of
the areas. The pointer for best practices is appreciated, and all new code
should follow that format.
> Correctly rethrow exceptions without swallowing the stack trace
> ---------------------------------------------------------------
>
> Key: AMQNET-433
> URL: https://issues.apache.org/jira/browse/AMQNET-433
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ
> Reporter: Daniel Marbach
> Assignee: Jim Gomes
> Priority: Trivial
> Fix For: 1.6.0
>
>
> When looking through the code I saw a lot of the following code snippets:
> try
> {
> }
> catch(AnyException ex)
> {
> // do something
> throw ex;
> }
> This WILL rewrite the stack trace and is not considered best practice. I
> suggest you change the appropriate places in the code to:
> try
> {
> }
> catch(AnyException ex)
> {
> // do something
> throw;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
