[
https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256951#comment-14256951
]
Dejan Bosanac commented on AMQ-5378:
------------------------------------
Hi Marc,
I pulled in most of your changes.
- I didn't change default memory limits, as current value is sensible option
for most users
- I didn't brought in the default options in activemq script as we sourced them
to the env script for the exact reason to have them out of this one
- Also, the last improvement on checking the broker running/not running is
broken in some ways. First it creates a pid file for each call, which is
unnecessary. Additionally, I don't think it's the script's job to determine
that broker is running/not running for most of these commands. If you call
browse or bstat it should just behaves like a client script and connect to the
jmx url (local or remote) and display the error if it can't. Note that error is
not just that broker is not running, but can be other stuff, like wrong url or
security credentials, so it's not good to hide that from users. In my opinion,
the current script covers all that well and we should leave it as is.
> Initscript refactoring: setup function seems to be broken, removal of
> uneccessary files, fix various problems
> -------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-5378
> URL: https://issues.apache.org/jira/browse/AMQ-5378
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.10.0
> Environment: Linux/Unix
> Reporter: Marc Schöchlin
> Labels: assemblies
> Fix For: 5.11.0
>
> Attachments: AMQ-5378.patch
>
>
> The current initscript seems to be broken.
> I submitted the current unix init script (see AMQ-2453) - the original script
> seems to be modified in a way which breaks the "setup" function
> If you call "./activemq setup ~/.activemq" you get a really messy configfile.
> The current distribution also contains lots of files of the java service
> wrapper which are not needed anymore.
> I created the following patch/pull request:
> https://github.com/apache/activemq/pull/46
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
