[
https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263832#comment-14263832
]
ASF GitHub Bot commented on AMQ-5378:
-------------------------------------
GitHub user scoopex opened a pull request:
https://github.com/apache/activemq/pull/54
Remaining changes create in context of AMQ-5378
This pullrequest assembles various changes which stabilize and improve the
activemq unix init script.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/breuninger-ecom/activemq trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit dc8487f92b007457f00cb89e83793f484d26b7b9
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T07:26:57Z
Remove fragments of the setup option
commit b55b96c00e9699cee7fd8fef1b4a5fba90c2de01
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:23:36Z
improve configuration file loading
Load only the first available configuration file to prevent confusion in
overloading of configuration parameters
commit a114fc7e9e0172b84d037d1ccb37ef75def493a2
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:31:25Z
remove hostname from pidfile, minor fixes
This creates problems if the hostname changes (i.e. if you use puppet)
commit d41274bb27616404a7968fbc0abfc9463622b22c
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:34:07Z
change to the correct variable
commit 83b30a68caa3bcacb15afd61bae0899cad463f44
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:35:12Z
ensure that /bin/sh is always used
commit 9f78c01bbd5de0ddf2a1b06ac518d451f7d5bc7c
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:37:43Z
quote assigned values to prevent problems with empty filenames
commit 659ca8c232436c940a1f3fa714357bb1ab034ee9
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:38:35Z
improve quoting, improve pidfile handling
quote assigned values to prevent problems with empty filenames
use a more reliable pidfile path
commit e6c01a2778d76e8b85a0bb46335bfbbc9207cda8
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T08:39:53Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit a34af4c9aa84f5b4a6178b431b8049962709839d
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T12:16:20Z
Handle the environment file properly
commit 22c87b16e3c340f9963fbfe21aee54ce99ed0893
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T12:16:58Z
Beatify the help output
commit 346ba2d22771fea4118ac7998609440fae072c4d
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T14:01:58Z
Better memeory defaults
commit 7cc368a890972c9b19c44e23b3cb40d133809fe3
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T14:15:42Z
evaluation of default parameter files
Make the order of the default configuration file forder more logical and
fix a bug caused by a unser variable.
commit 35c4138a3d2185ba33c50f803395edfda6577907
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-10T14:17:29Z
Improve testsuite
commit 0081cc59616c1fdc13f830ec3972af99087af4e5
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-11T07:12:46Z
added testsuite
This testsuite helps to ensure the proper operation of the unix init
script on various unix platforms (Linux, OSX, ...)
commit 65726ef61f44c75999317cff77af6850d6a5186c
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-11T09:47:29Z
check for local running broker, testing improvment
Prevous releases checked for a local running broker but missed that this
tool is also usable to connect to remote brokers for options like
query, bstat, dstat, purge and browse.
The new behavior is different: If the script uses the '--jmxurl' or
'--amqurl' from the configuration file (i.e. 'env') it checks that the
local broker is running. If the '--jmxurl' or '--amqurl' is specified as
an commandline option the check is not performed.
The previous change alos resulted in a different behavior for the
testcases. The testsuite can now be executed successfully on Ubuntu
14.04 (which uses /bin/dsh) and OSX.
commit 6ff185e6ba44fde94754ac12716609f5ca232331
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-11T09:55:08Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit eee7a7ba7e6e9439980f342910bbf5e03a1cf787
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-11T17:39:46Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit b257826b06ce4cfd38281589a0fc99dd3e2f8df6
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-17T22:01:26Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit 90ddd79a04f6ddabbab4d483b1947e02a1e60d05
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-27T19:05:55Z
Merge from upstream
commit 41e4f281ec3cbb4c29bbc8a15c25f4946c5c34b2
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-27T19:27:49Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit 4d3305ae053e8354ad0c241988d8b006de512517
Author: Marc Schoechlin <[email protected]>
Date: 2014-12-29T07:00:28Z
Merge branch 'trunk' of github.com:breuninger-ecom/activemq into trunk
commit 27f014c859f82f6e7d3ab718b899d41ccabb001f
Author: Marc Schoechlin <[email protected]>
Date: 2015-01-04T10:22:37Z
Merge remote-tracking branch 'upstream/trunk' into trunk
----
> Initscript refactoring: setup function seems to be broken, removal of
> uneccessary files, fix various problems
> -------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-5378
> URL: https://issues.apache.org/jira/browse/AMQ-5378
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.10.0
> Environment: Linux/Unix
> Reporter: Marc Schöchlin
> Assignee: Dejan Bosanac
> Labels: assemblies
> Fix For: 5.11.0
>
> Attachments: AMQ-5378.patch
>
>
> The current initscript seems to be broken.
> I submitted the current unix init script (see AMQ-2453) - the original script
> seems to be modified in a way which breaks the "setup" function
> If you call "./activemq setup ~/.activemq" you get a really messy configfile.
> The current distribution also contains lots of files of the java service
> wrapper which are not needed anymore.
> I created the following patch/pull request:
> https://github.com/apache/activemq/pull/46
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
