Github user jimbogithub commented on the pull request:
https://github.com/apache/activemq-artemis/commit/b1b4bb8a32a9bb9c6d951f3d0fdd3626944319f9#commitcomment-15229633
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
on line 105:
Thanks, that should fix my issue. Can I tempt you to change the
`readyListeners` to be a `LinkedHashSet`? That would also avoid any leakage
when `!ready` and give you insertion order iteration. Plus you don't need a
concurrent class as you have the synchronized blocks. The leak is small as the
`$Nodes` are small but the GC cost is very expensive due to the quantity of
them (references processed etc). Not sure how long `!ready` can remain true
but if it's long enough for a a few thousand messages to be sent then I think
this change should also be made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
