Dear devs, I'm afraid I cannot create a good enough docker image as two constraints clash:
- Cannot use a different repository (as per John's) - Should have a proper docker specific README.md file in the docker hub page (as per my personal preference). This won't change unless, the issue 292 <https://github.com/docker/hub-feedback/issues/292> in docker hub gets fixed. I'll keep an eye on the issue in case it gets fixed (feb 18 they wrote <https://github.com/docker/hub-feedback/issues/292#issuecomment-185811039>: *We have a plan in place and will provide an update as soon as we can*) , and will keep maintaining my personal docker image. Regards 2016-08-14 10:31 GMT-07:00 Victor <victor.rom...@gmail.com>: > Hi John, devs > > I hear your expectations and I'm following option two, the thrift/marmotta > approach for that reason. > > There is some maintenance I'd like to happen to avoid ending up with > images like thrift, that only has *latest > <https://hub.docker.com/r/apache/thrift/tags/> *and not one tag per each > version as I'd like it to have. I can update RELEASING.md > <https://github.com/apache/activemq-artemis/blob/master/RELEASING.md> in > the same PR with some very short instructions on how to change the version > in the Dockerfile (very simple) on every release. > > The whole *latest is meant to be SNAPSHOT* is an open and broader > discussion. But if the greater apache, as it seems, consider latest is a > non repeatable SNAPSHOT build, I'm happy with it. > > Regards > > > 2016-08-14 9:06 GMT-07:00 John D. Ament <johndam...@apache.org>: > >> Hey Victor, >> >> To clarify. I'm expecting that a build of artemis results in the >> creation (and publishing) of a docker container. This container represents >> the underlying build artifact. This is known as the "latest" in docker. >> When doing a release, i expect something similar. >> >> The ASF only does automatic docker builds. Not manual. Based on input I >> got from our infra, its never a separate repo, always in the same repo. >> Granted we don't have a ton of examples yet, but that seems to be the go-to >> (and realistically represents a true CI/CD pattern for completely running >> apps like this). >> >> The actual creation of the container is a separate step in jenkins. So >> once the current dockerfile is donated, pointing to a different location >> for the binary, I can carry out the steps w/ infra to setup the docker >> builds. There shouldn't be a reason to point to a remote location for the >> binary as a result, it'll all be local to the workspace. I'll probably >> need to setup some kind of job to build releases, but shouldn't be a big >> issue. >> >> You can find a few examples out on our ASF hub page - >> https://hub.docker.com/u/apache/. Thrift is the most curious one from >> my POV. It actually builds thrift on the image, and uses an entry point to >> allow extension (e.g. execution of thrift). >> >> Also apologies, I missed that this fell off the dev list. >> >> John >> >> >> On Sun, Aug 14, 2016 at 1:30 AM Victor <victor.rom...@gmail.com> wrote: >> >>> Hi John, >>> >>> You mentioned building SNAPSHOTs and it sounds great to me. The problem >>> is that one does not just curl the latest version of a SNAPSHOT. There are >>> many rolling versions >>> <https://repository.apache.org/content/repositories/snapshots/org/apache/activemq/apache-artemis/1.4.0-SNAPSHOT> >>> . >>> >>> Also SNAPSHOTs would generate an interesting scenario when releasing >>> versions, as the docker file for a snapshot would be different than the >>> dockerfile of a RELEASE. Therefor, someone (I can do it if necessary) has >>> to make sure the Dockerfile is updated accordingly by taking the dockerfile >>> from the latest release version (or uncomment code perhaps). Therefor I'd >>> discard the obvious workarounds (see below two examples): >>> >>> - Curlling the maven metadata >>> >>> <https://repository.apache.org/content/repositories/snapshots/org/apache/activemq/apache-artemis/1.4.0-SNAPSHOT/maven-metadata.xml> >>> of the SNAPSHOT, and with xmlstarlet extract the latest version. >>> - Using the nexus api >>> >>> <https://repository.apache.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.activemq&a=apache-artemis&v=LATEST> >>> (although I haven been able to make it work, but just spent 10m). Tied to >>> an specific maven repo software. Unclear to me how to validate >>> >>> Even if we forget about the SNAPSHOTS, there has to be a clear release >>> mechanism if the dockerfile lives inside of the main repo. Because it does >>> download releases versions from an external site (not from the reactor) and >>> validates against a manually given signature. >>> >>> The approaches I see are: >>> >>> 1. Non automatic dockerhub build. Build and upload to dockerhub >>> using a maven plugin. Would ease maintenance. Users of dockerhub prefer >>> automatic builds, but overall it would be great experience both for users >>> and developers. Would probably make >>> 2. Automatic dockerhub build that actually builds Artemis in >>> dockerhub (skipping tests). The image that is meant to be as small as >>> possible, it will likely have some leftovers, probably not to many if >>> done >>> carefully. This is the same approach marmotta >>> <https://github.com/apache/marmotta/blob/develop/Dockerfile> uses. >>> 3. Use a different repo just as it is right now and ignore >>> SNAPSHOTS. Proven to work and I'd say 99% of the dockerhub projects work >>> like that. >>> >>> 3 is the current path but I'll discard it for one single reason: no >>> other apache project seems to follow it. >>> >>> Personally I don't want to go through the 1 route, as it would require >>> the apache dockerhub credentials to be store in the apache CI. And I'm sure >>> someone, somewhere would have problems with that. Otherwise is a perfectly >>> valid approach. >>> >>> So unless you have any other idea, I'd go for the option 2 as soon as I >>> can. >>> >>> >>> >>> >>> >>> >>> >>> >>> 2016-08-12 19:58 GMT-07:00 Victor <victor.rom...@gmail.com>: >>> >>>> Hi John, >>>> >>>> Apologies I have just arrived back from a travel. I'll put it together >>>> this very weekend and I'll let you know. >>>> >>>> Thanks for the help. >>>> >>>> 2016-08-12 18:56 GMT-07:00 John D. Ament <john.d.am...@gmail.com>: >>>> >>>>> Hey Victor, >>>>> >>>>> Just wondering if you were able to get this together? Unfortunately, >>>>> the ActiveMQ permissions don't let me assign to you. >>>>> >>>>> John >>>>> >>>>> On Fri, Jul 29, 2016 at 6:41 PM Victor <victor.rom...@gmail.com> >>>>> wrote: >>>>> >>>>>> Nice! Feel free to assign to me : "vromero". >>>>>> >>>>>> 2016-07-29 15:10 GMT-07:00 John D. Ament <john.d.am...@gmail.com>: >>>>>> >>>>>>> Also, I created a ticket in JIRA for this: https://issues.apache.or >>>>>>> g/jira/browse/ARTEMIS-658 >>>>>>> >>>>>>> John >>>>>>> >>>>>>> On Fri, Jul 29, 2016 at 5:58 PM John D. Ament < >>>>>>> john.d.am...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi Victor, >>>>>>>> >>>>>>>> Basically, that's a working example of how ASF does docker builds. >>>>>>>> They setup an automated build per branch. >>>>>>>> >>>>>>>> John >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Jul 29, 2016 at 5:37 PM Victor <victor.rom...@gmail.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi John, >>>>>>>>> >>>>>>>>> Thank you! Excellent stuff, I'll take care of it. BTW yes I'm in >>>>>>>>> dev@active. >>>>>>>>> >>>>>>>>> The only thing I don't fully comprehend is the thrift one. How >>>>>>>>> does thrift applies here? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 2016-07-29 13:29 GMT-07:00 John D. Ament <john.d.am...@gmail.com>: >>>>>>>>> >>>>>>>>>> Ok, I just dug around a bit on how we have docker setup. >>>>>>>>>> Everything is an automated build, so we can have it build based on >>>>>>>>>> the code >>>>>>>>>> in Artemis. I would recommend as a first step to raise a PR to >>>>>>>>>> contribute >>>>>>>>>> the dockerfile and entry point to the artemis repo. I can setup a >>>>>>>>>> build >>>>>>>>>> then in docker hub to build our master. >>>>>>>>>> >>>>>>>>>> Some minor changes: >>>>>>>>>> >>>>>>>>>> - Instead of downloading from the mirrors, download the artifact >>>>>>>>>> from the repository, this way we can do 1.4 snapshots in addition to >>>>>>>>>> the >>>>>>>>>> released binaries. >>>>>>>>>> - You may want to base it on thrift, https://github.com/apa >>>>>>>>>> che/thrift >>>>>>>>>> - Make sure ASF license headers are present. >>>>>>>>>> >>>>>>>>>> John >>>>>>>>>> >>>>>>>>>> On Fri, Jul 29, 2016 at 4:06 PM John D. Ament < >>>>>>>>>> john.d.am...@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hey Victor, >>>>>>>>>>> >>>>>>>>>>> Are you already subscribed on dev@activemq? >>>>>>>>>>> >>>>>>>>>>> Basically from what I understand, we do automated builds into >>>>>>>>>>> the docker hub. So we wouldn't directly bring in your image, but >>>>>>>>>>> if you >>>>>>>>>>> have the source code we can implement it as a partof our build. >>>>>>>>>>> >>>>>>>>>>> What do you use to build your docker container? >>>>>>>>>>> >>>>>>>>>>> John >>>>>>>>>>> >>>>>>>>>>> ---------- Forwarded message --------- >>>>>>>>>>> From: John D. Ament <johndam...@apache.org> >>>>>>>>>>> Date: Fri, Jul 29, 2016 at 3:52 PM >>>>>>>>>>> Subject: Re: Contributing to the Apache Docker Account >>>>>>>>>>> To: Bruce Snyder <bruce.sny...@gmail.com> >>>>>>>>>>> Cc: Victor <victor.rom...@gmail.com>, <dev@activemq.apache.org> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> But yes I'll take care of it >>>>>>>>>>> >>>>>>>>>>> On Jul 29, 2016 15:51, "John D. Ament" <johndam...@apache.org> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> I believe that's an infra question >>>>>>>>>>>> >>>>>>>>>>>> On Jul 29, 2016 15:47, "Bruce Snyder" <bruce.sny...@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Well so far nobody has responded. So I have no idea who >>>>>>>>>>>>> controls it. We need to find out who controls access to the ASF >>>>>>>>>>>>> account at >>>>>>>>>>>>> Docker Hub. >>>>>>>>>>>>> >>>>>>>>>>>>> Bruce >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Jul 29, 2016 at 1:02 PM, Victor < >>>>>>>>>>>>> victor.rom...@gmail.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Bruce, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Any information would be highly appreciated. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> >>>>>>>>>>>>>> 2016-07-13 15:43 GMT-07:00 Bruce Snyder <bsny...@apache.org>: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> John, can you help out Victor with his request to contribute >>>>>>>>>>>>>>> his image to the ASF account at Docker Hub? It looks like you >>>>>>>>>>>>>>> were the last >>>>>>>>>>>>>>> one to respond to Victor's request who has knowledge of the ASF >>>>>>>>>>>>>>> account at >>>>>>>>>>>>>>> Docker Hub. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Is there anyone else who can help Victor get his Docker >>>>>>>>>>>>>>> image contributed so that it can be listed under the ASF >>>>>>>>>>>>>>> account at Docker >>>>>>>>>>>>>>> Hub? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Bruce >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> ---------- Forwarded message ---------- >>>>>>>>>>>>>>> From: Ted Husted <human-respo...@apache.org> >>>>>>>>>>>>>>> Date: Tue, Jul 12, 2016 at 5:52 PM >>>>>>>>>>>>>>> Subject: Re: Contributing to the Apache Docker Account >>>>>>>>>>>>>>> To: Victor <victor.rom...@gmail.com> >>>>>>>>>>>>>>> Cc: bsny...@apache.org >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thank you for your inquiry. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> As Artemis is a subproject of ActiveMQ, the best person to >>>>>>>>>>>>>>> contact with this question is the ActiveMQ PMC Chair. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I believe Bruce Snyder is the current PMC Chair. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> You may also wish to refer to the project's Contributing >>>>>>>>>>>>>>> page. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> * https://activemq.apache.org/contributing.html >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hope that helps, Ted Husted. >>>>>>>>>>>>>>> Member Emeritus, Apache Software Foundation. >>>>>>>>>>>>>>> * http://www.apache.org/foundation/preFAQ.html >>>>>>>>>>>>>>> * http://apache.org/foundation/faq.html >>>>>>>>>>>>>>> * http://www.apache.org/foundation/licence-FAQ.html >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Jul 11, 2016 at 2:18 PM, Victor < >>>>>>>>>>>>>>> victor.rom...@gmail.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Dear Apache, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Since Sep 27, 2015 I have an Apache Artemis docker image >>>>>>>>>>>>>>>> on docker hub >>>>>>>>>>>>>>>> <https://hub.docker.com/r/vromero/activemq-artemis/> (> >>>>>>>>>>>>>>>> 700 installations, 1 pull request, 1 stackoverflow and no >>>>>>>>>>>>>>>> complains). >>>>>>>>>>>>>>>> I have already shared it with the Apache Artemis team and it >>>>>>>>>>>>>>>> seems to be a >>>>>>>>>>>>>>>> common agreement (between the few that replied the thread >>>>>>>>>>>>>>>> <http://mail-archives.apache.org/mod_mbox/activemq-dev/201604.mbox/%3CCAOqetn8FG_Yz+eqFXuE=oxd1hkjepbgolqy63eq3a22epun...@mail.gmail.com%3E>) >>>>>>>>>>>>>>>> that if contributed it should be in the Apache docker user. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Although there seems to be no specific Apache contact >>>>>>>>>>>>>>>> related to Docker. That is why I'm writting you. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I'm specifically looking for someone to ask for any >>>>>>>>>>>>>>>> specific the process and artifacts that might be required. I >>>>>>>>>>>>>>>> already signed >>>>>>>>>>>>>>>> the contributors agreement, I'm looking for things like special >>>>>>>>>>>>>>>> documentation, move it to a given repo, etc. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regards >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> perl -e 'print unpack("u35", "\@0G)U8V4\@4VYY9&5R\"F)S;GED9 >>>>>>>>>>>>>>>> 7)\`87!A8VAE+F]R9PH\`");' >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ActiveMQ in Action: http://bit.ly/2je6cQ >>>>>>>>>>>>>>>> Blog: http://bruceblog.org/ >>>>>>>>>>>>>>>> Twitter: http://twitter.com/brucesnyder >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9& >>>>>>>>>>>>> 5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );' >>>>>>>>>>>>> >>>>>>>>>>>>> ActiveMQ in Action: http://bit.ly/2je6cQ >>>>>>>>>>>>> Blog: http://bsnyder.org/ <http://bruceblog.org/> >>>>>>>>>>>>> Twitter: http://twitter.com/brucesnyder >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>> >>>> >>> >
