Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/740#discussion_r76801952
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
@Override
- public boolean checkDataReceived() {
- boolean res = dataReceived;
-
- dataReceived = false;
-
- return res;
+ public void flush() {
+ checkInactivity();
}
- @Override
- public void flush() {
+ private void checkInactivity() {
+ if (!this.useKeepAlive) {
--- End diff --
You still need to set dataReceived to false, otherwise the TTL from
ConnectionFActory will kick in and this will be killed per inactivity.
TTL in should be done by the dataREcieved attribute from the super class.
Sending a TTL to the client should be a different thing. i think it's just
a matter to send the TTL back to the client.
You have changed way more than needed I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
