Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/740#discussion_r76989641
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
@Override
- public boolean checkDataReceived() {
- boolean res = dataReceived;
-
- dataReceived = false;
-
- return res;
+ public void flush() {
+ checkInactivity();
}
- @Override
- public void flush() {
+ private void checkInactivity() {
+ if (!this.useKeepAlive) {
--- End diff --
we don't need call super because we don't need to do anything special here,
the super will always be called if we don't override it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
