Yeah... that's what I meant by the "This closes #..." but if you are rejecting a PR, you will need the empty commit living in a branch.
If we are ok with that, we can just add the empty commit. On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > You can also create a "fake" commit containing "This closes #...". > > No need to request infra imho. > > Regards > JB > > > > On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <clebert.suco...@gmail.com> > wrote: >>There are ways to close a PR on Apache mirrors: >> >>- by merging the PR >>- by adding a commit saying. >> "This closes #NR" >>- by asking infra >> >> >>If the PR is stale you will need to ask infra. As no one outside the >>Apache >>infra have auth to close the PR. >> >>On Sunday, October 23, 2016, Jean-Baptiste Onofré <j...@nanthrax.net> >>wrote: >> >>> Good idea Hadrian. >>> >>> I will try to take a look. >>> >>> Regards >>> JB >>> >>> >>> >>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbar...@gmail.com >>> <javascript:;>> wrote: >>> >There are a number of old, even very old, PRs open [1]. Some I >>suspect >>> >are not relevant anymore. It'd be great if somebody could look into >>> >them >>> >and close them down. I will try to find some time next week and help >>> >with that as well. >>> > >>> >Cheers, >>> >Hadrian >>> > >>> >[1] https://github.com/apache/activemq/pulls >>> >> >> >>-- >>Clebert Suconic -- Clebert Suconic
