although we could deprecate this xml tag, and add a new one with some creative name... add exceptions on the logs.. what would make it suitable for even a minor update, on which case this would bee a regular issue.
On Fri, Feb 10, 2017 at 5:06 PM, Clebert Suconic <[email protected]> wrote: > I guess it's just simplification? one is in seconds, the other is in minutes? > > It seems something we should fix.. but it needs to be done on a major > release. (it would break minor updates). > > On Fri, Feb 10, 2017 at 4:58 PM, Justin Bertram <[email protected]> wrote: >> What's the use-case for needing to "align" <slow-consumer-threshold> and >> <slow-consumer-check-period>? >> >> >> Justin >> >> ----- Original Message ----- >> From: "Jiri Danek" <[email protected]> >> To: [email protected] >> Sent: Friday, February 10, 2017 3:26:01 PM >> Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream >> >> On Thu, Feb 9, 2017 at 1:18 PM, Martyn Taylor <[email protected]> wrote: >> >>> I'd like to open discussion around this topic, does anyone have any >>> suggestions, or can think of anything that is needed before we go ahead >>> with a major release? This is the perfect time to do anything that could >>> break APIs, drop deprecated methods support, break data format etc... >>> >> >> What about changing units on config option >> >> <slow-consumer-threshold>100</slow-consumer-threshold> >> >> currently it is in messages/second, I suggest using messages/minute, to >> align it with >> >> <slow-consumer-check-period>5</slow-consumer-check-period> >> >> which is in minutes. >> >> -- >> Jiří Daněk > > > > -- > Clebert Suconic -- Clebert Suconic
