Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1263
@michaelandrepearce
Re 1:
agree with sorrow: I've to admit that an all-out primitive solution would
be ideal in the long term (in GC terms) , but with too many effects in the
short one and...is a breaking change.
Re 2:
agree, me too, I've to check the code better!
Re 3:
depends: giving its fixed size, collisions will exists but we know how we
generates the ids :) and this will help to choose the hashed function wisely
(is not a general purpose interner/cache).
But I agree on the size of the cache (I tends to size interners of about 16
elements, max 32 in general, to be more cache effective): avoid magic
numbers/tuning is better.
And it will add complexities too!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
