Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1337#discussion_r121737539
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpClientTestSupport.java
---
@@ -155,6 +155,7 @@ protected ActiveMQServer createServer(int port) throws
Exception {
server.getConfiguration().setPagingDirectory(server.getConfiguration().getPagingDirectory()
+ port);
server.getConfiguration().setJMXManagementEnabled(true);
server.getConfiguration().setMessageExpiryScanPeriod(5000);
+ server.getConfiguration().setUseLegacyAMQPQueueNaming(false);
--- End diff --
I don't think the tests should override the default like this, it means
none of the tests would be testing the default behaviour of the broker.
Explicit tests that verify non-default behaviours would be more appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
