Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1337#discussion_r121733233
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
 ---
    @@ -442,6 +442,8 @@ public static String getDefaultHapolicyBackupStrategy() 
{
        // Default period to wait between configuration file checks
        public static final long DEFAULT_CONFIGURATION_FILE_REFRESH_PERIOD = 
5000;
     
    +   public static final boolean DEFAULT_LEGACY_AMQP_QUEUE_NAMING = true;
    --- End diff --
    
    It would be good to mention it is "subscription queues" being affected in 
the constant name. I'm not sure calling the still-default behaviour 'legacy' 
makes sense, especially as a future change might not just be to flip the 
boolean here to false but perhaps instead change both the AMQP and Core naming 
schemes to something without the existing issues. Perhaps flipping the boolean 
now and calling it something like "USE_CORE_SUBSCRIPTION_QUEUE_NAMES_FOR_AMQP"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to