Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1515#discussion_r137456280
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalMeasure.java
---
@@ -17,28 +17,39 @@
package org.apache.activemq.artemis.utils.critical;
-import org.jboss.logging.Logger;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLongFieldUpdater;
-public class CriticalMeasure {
+final class CriticalMeasure {
--- End diff --
Why change it? Else we end up just flip flopping this based on people's own
design pref. It's out of scope of the change eg it's not needed
---
