Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1590#discussion_r145071633
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
---
@@ -158,11 +162,29 @@ public void testBytesMessageSendReceive() throws
Throwable {
}
@Test(timeout = 60000)
- public void testMessageSendReceive() throws Throwable {
+ public void testBytesMessageSendReceiveFromAMQPToAMQP() throws
Throwable {
+ testBytesMessageSendReceive(createConnection(), createConnection());
+ }
+
+ @Test(timeout = 60000)
+ public void testBytesMessageSendReceiveFromCoreToAMQP() throws
Throwable {
+ testBytesMessageSendReceive(createCoreConnection(),
createConnection());
+ }
+
+ @Test(timeout = 60000)
+ public void testBytesMessageSendReceiveFromCoreToCore() throws
Throwable {
--- End diff --
This (and the others like it) seems like it should be a duplicate of an
existing test. Even if not, having it under the amqp test package doesn't seem
that great.
---
