Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1590#discussion_r145072050
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
 ---
    @@ -158,11 +162,29 @@ public void testBytesMessageSendReceive() throws 
Throwable {
        }
     
        @Test(timeout = 60000)
    -   public void testMessageSendReceive() throws Throwable {
    +   public void testBytesMessageSendReceiveFromAMQPToAMQP() throws 
Throwable {
    +      testBytesMessageSendReceive(createConnection(), createConnection());
    +   }
    +
    +   @Test(timeout = 60000)
    +   public void testBytesMessageSendReceiveFromCoreToAMQP() throws 
Throwable {
    +      testBytesMessageSendReceive(createCoreConnection(), 
createConnection());
    +   }
    +
    +   @Test(timeout = 60000)
    +   public void testBytesMessageSendReceiveFromCoreToCore() throws 
Throwable {
    --- End diff --
    
    Its so we check cross compatibly to and from amqp. see other similar test 
cases, the core to core ones are just completeness on the combinations.


---

Reply via email to