Ok...I consider it fixed.. removed my -1.. I will do some more work before sending my vote.
On Wed, Nov 1, 2017 at 1:02 PM, Justin Bertram <[email protected]> wrote: > Should be fixed now. Let me know if I messed up. :) > > > Justin > > On Wed, Nov 1, 2017 at 11:50 AM, Clebert Suconic <[email protected]> > wrote: > >> Actually, I don't need to -1 >> >> >> just git tag again on top of that... re-upload the tag. >> >> On Wed, Nov 1, 2017 at 12:48 PM, Clebert Suconic >> <[email protected]> wrote: >> > -1 >> > >> > The 2.4.0 is at 8a5961c805b3926b0932d5c1e826238ba88d2674, while the >> > same commit on master is at ec63189a0a8235fc0436d9554bcdf323944e1bf6 >> > >> > (for the record, I spoke to Justin... it happened that he squahsed the >> > upgrade to extra tests on the same commit.. while the tag was on a >> > different commit). >> > >> > >> > I would prefer to keep the commits from master.. one thing I do (and I >> > believe other people will do) is to: >> > >> > git log 2.3.0..2.4.0 >> > >> > >> > This would break that usage. >> > >> > >> > >> > On Wed, Nov 1, 2017 at 2:53 AM, Justin Bertram <[email protected]> >> wrote: >> >> I would like to propose an Apache ActiveMQ Artemis 2.4.0 release. >> >> >> >> We had these new features and improvements added as part of 2.4.0: >> >> >> >> [ARTEMIS-534] - Allow JMX configuration from broker.xml >> >> [ARTEMIS-1447] - JDBC NodeManager to support JDBC HA Shared Store >> >> [ARTEMIS-1428] - Allow configuration of max frame payload length for >> STOMP >> >> web-socket >> >> [ARTEMIS-1463] - Implement rbac of management objects >> >> >> >> The release notes can be found here: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> version=12341540&projectId=12315920 >> >> >> >> Source and binary distributions can be found here: >> >> https://repository.apache.org/content/repositories/ >> >> orgapacheactivemq-1153/org/apache/activemq/apache-artemis/2.4.0/ >> >> >> >> The Maven repository is here: >> >> https://repository.apache.org/content/repositories/ >> orgapacheactivemq-1153 >> >> >> >> In case you want to give it a try with the maven repo on examples: >> >> http://activemq.apache.org/artemis/docs/latest/hacking- >> >> guide/validating-releases.html >> >> >> >> The source tag: >> >> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis. >> >> git;a=tag;h=refs/tags/2.4.0 >> >> >> >> I will update the website after the vote has passed. >> >> >> >> >> >> [ ] +1 approve the release as Apache Artemis 2.4.0 >> >> [ ] +0 no opinion >> >> [ ] -1 disapprove (and reason why) >> >> >> >> Here's my +1 >> >> >> >> >> >> Justin >> > >> > >> > >> > -- >> > Clebert Suconic >> >> >> >> -- >> Clebert Suconic >> -- Clebert Suconic
