Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978616
  
    --- Diff: 
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java
 ---
    @@ -465,11 +467,17 @@ public synchronized boolean createQueue(final boolean 
storeConfig,
                                                final String selectorString,
                                                final boolean durable,
                                                final String... bindings) 
throws Exception {
    -      return internalCreateJMSQueue(storeConfig, queueName, 
selectorString, durable, false, bindings);
    +      return internalCreateJMSQueue(storeConfig, queueName, queueName, 
selectorString, durable, false, bindings);
    +   }
    +
    +   @Override
    +   public boolean createQueue(boolean storeConfig, String queueName, 
String jmsQueueName, String selectorString, boolean durable, String... 
bindings) throws Exception {
    --- End diff --
    
    As per other comment, not sure why adding new methods here. If the reason 
for this change is just back compatibility of ActiveMQDestination. 


---

Reply via email to