Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161979093
  
    --- Diff: 
tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
    @@ -49,6 +50,11 @@ if (method.equals("write")) {
         topic = new ActiveMQTopic("topic")
         temporary = ActiveMQDestination.createTemporaryQueue("whatever")
         temporaryTopic = ActiveMQDestination.createTemporaryTopic("whatever")
    +    if (version.equals("ARTEMIS-SNAPSHOT")) {
    +        destination = new ActiveMQDestination("address", "name", 
ActiveMQDestination.TYPE.DESTINATION, null)
    --- End diff --
    
    Same as other comment, for 2.x this really should be using the non "name" 
constructor this constructor should be deprecated.


---

Reply via email to