Github user jmesnil commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1783#discussion_r162028476
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
 ---
    @@ -19,10 +19,18 @@
     import java.util.Map;
     
     import org.apache.activemq.artemis.api.core.Message;
    +import org.apache.activemq.artemis.core.server.ServerMessage;
     
     public interface Transformer {
    --- End diff --
    
    The interface that needs to support backwards compatibility is 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/Transformer.java
 not this one (this interface is new in Artemis 2.x)
    I was suggesting to add default methods to the cluster's interface instead 
of adding deprecated  method to the new one.


---

Reply via email to