Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162048935
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import java.util.Map;
import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.core.server.ServerMessage;
public interface Transformer {
--- End diff --
@jmesnil Perhaps I am missing something here. But, this new interface is
what we use internally. If I was to add these changes to the old interface I
would need to check the Transformer Type at runtime and do a cast before
calling the appropriate method. I wanted to avoid this as it has impact on
performance. The way it is at the moment there's only a performance hit when
using the 1.x interfaces.
---
