Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162131538
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V2.java
---
@@ -25,16 +25,21 @@
protected boolean autoCreateQueues;
+ protected boolean autoCreateQueuesDurable;
--- End diff --
Why you are adding this if this is not being written anywhere?
Also... this change is wrong.. you would need a _V5 with the new field
being written...
But honestly... there has been so any versions on
SessionBindingQueryResponse... can you add a V5 with a hashMap for new fields?
in the future we would just add more metadata instead of changing the packet.
---
