Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164165293
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
*/
if (!response.isExists() ||
!response.getQueueNames().contains(dest.getSimpleAddress())) {
if (response.isAutoCreateQueues()) {
+ SimpleString queueNameToUse = dest.getSimpleAddress();
+ SimpleString addressToUse = queueNameToUse;
+ RoutingType routingTypeToUse = RoutingType.ANYCAST;
+ if
(CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
+ CompositeAddress compositeAddress =
CompositeAddress.getQueueName(queueNameToUse.toString());
+ addressToUse = new
SimpleString(compositeAddress.getAddress());
+ queueNameToUse = new
SimpleString(compositeAddress.getQueueName());
+ routingTypeToUse = RoutingType.MULTICAST;
--- End diff --
Eg I think it should be constrained on core. As really virtual topics was a
pre cursor custom impl of shared subscriptions in JMS 2 spec which we have
already
---
