Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282547
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
---
@@ -38,6 +38,10 @@ public static MessageReference createReference(Message
encode, final Queue queue
Message getMessage();
+ default long getMessageID() {
--- End diff --
-1 on hot path default methods on hot path aren't so good, suggest either
leaving the code as was in ServerConsumerImpl with the
getMessage().getMessageId or simply not make it default, and update other
impl's within the code base.
nudge @franz1981
---
