Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1827#discussion_r165348688
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
---
@@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx,
MessageReference ref, long tim
@Override
public void afterCommit(final Transaction tx) {
for (MessageReference ref : refsToAck) {
- synchronized (ref.getQueue()) {
--- End diff --
Makes sense. I think best way of getting confidence is a really good test
case to prove it
---
