Github user clebertsuconic commented on a diff in the pull request:
    --- Diff: 
    @@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
    -      singleThreadExecutor = executorFactory.getExecutor();
    +      ThreadFactory tFactory = AccessController.doPrivileged(new 
PrivilegedAction<ThreadFactory>() {
    +         @Override
    +         public ThreadFactory run() {
    +            return new ActiveMQThreadFactory("ActiveMQ-journal-server-" + 
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
    +         }
    +      });
    +      singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
    --- End diff --
    nope.. that's wrong...
    executorFactory.getExecutor() is returning on thread executor from the pool.
    it won't always be the same thread.. but it will always be the same 
context.. this patch is not valid.
    in what situation do you see a deadlock.
    hornetq it might be different.. I would need a test to be able to accept a 
patch here. we should reuse the thread from the pool always.


Reply via email to