Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2011#discussion_r181025545
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/TextFileCertificateLoginModule.java
 ---
    @@ -71,8 +79,12 @@ protected String getUserNameForCertificates(final 
X509Certificate[] certs) throw
           if (certs == null) {
              throw new LoginException("Client certificates not found. Cannot 
authenticate.");
           }
    -
    -      return usersByDn.get(getDistinguishedName(certs));
    +      String dn = getDistinguishedName(certs);
    +      String name = usersByDn.get(dn);
    --- End diff --
    
    Hence this `userByDb` not synchronized access no longer exists in the new 
commit?
    With github and multiple commits is not simple to do reviews :P


---

Reply via email to