Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2149#discussion_r196724509
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
 ---
    @@ -80,4 +88,68 @@ public void inspectOpenedResource(Connection connection) 
{
           connection.close();
        }
     
    +   private static final String QUEUE_NAME = "queue://testHeartless";
    --- End diff --
    
    Why does a test named "testCloseConsumerOnConnectionReset" use a queue 
named "queue://testHeartless", when "testHeartless" is the name of a different 
test in the class? Does it need a "queue://" prefix? 
    I'd just use getTestName() inside the test get a helpful value.



---

Reply via email to