Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726336
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68 @@ public void inspectOpenedResource(Connection connection)
{
connection.close();
}
+ private static final String QUEUE_NAME = "queue://testHeartless";
+
+ // This test is validating a scenario where the client will leave with
connection reset
+ // This is done by setting soLinger=0 on the socket, which will make
the system to issue a connection.reset instead of sending a
+ // disconnect.
+ @Test(timeout = 60000)
+ public void testCloseConsumerOnConnectionReset() throws Exception {
--- End diff --
I dont really understand why this test is in the AmqpNoHearbeatsTest class,
it feels like it should operate about the same regardless whether AMQP
idle-timeout handling is enabled or not. Its definitely not where I would go
looking for such a test.
It also seems far more appropriate to testing the changes made in #2139 for
ARTEMIS-1927 (without test).
---
