[GitHub] activemq-artemis pull request #2175: ARTEMIS-856 - Support consumersBeforeDi...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2175#discussion_r201051073
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
    @@ -270,6 +271,15 @@
     
        private final QueueFactory factory;
     
    +   private final AtomicBoolean dispatching = new AtomicBoolean();
    --- End diff --
    
    The logic that involves using dispatching and dispatchStartTime could be 
simplyfied using just dispatchStartTime? 
    I would use and AtomicLongFieldUpdater for that in case


---