Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2175#discussion_r201073066
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
    @@ -270,6 +271,15 @@
     
        private final QueueFactory factory;
     
    +   private final AtomicBoolean dispatching = new AtomicBoolean();
    --- End diff --
    
    I wanted that when dispatching the quickest eval is done, thus why the 
seperate boolean. As it is hot path. Agree could just use != -1 check, memory 
vs cpu cycle. Let me know your thought 
    
    Agree re atomic updater, i can make this change. 


---

Reply via email to