Github user ricardozanini commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2241
  
    HI @michaelandrepearce! Thanks for your review.
    
    Regarding the sample and the differences between JMS Pool and Spring 
Caching feature, I'm going to edit the README file to enhance it with this 
details. I added the JMS Pool here because the 
[amqp-10-jms-spring-boot](https://github.com/amqphub/amqp-10-jms-spring-boot) 
itself is relying on it ([or if a reference to their classes are found in the 
classpath](https://github.com/amqphub/amqp-10-jms-spring-boot/blob/master/amqp-10-jms-spring-boot-autoconfigure/src/main/java/org/amqphub/spring/boot/jms/autoconfigure/AMQP10JMSAutoConfiguration.java#L58)).
 
    
    I may ask to the author why he's using JMS Pool instead of Spring's own 
feature. 
    
    > I mostly have an issue here that Pooled CF you're bringing in from your 
side project (messaginghub) is originally Apache ActiveMQ 5 code, that rather 
than you contributing any fixes or enhancements to this and porting either to a 
subproject in ActiveMQ or to Artemis as a submodule, youve decided to host 
outside Apache, and lose all the attribution that others have made over time, 
https://github.com/apache/activemq/commits/master/activemq-jms-pool
    
    I'm sorry, but I'm not the author of this project. If the code is came from 
ActiveMQ, I understand that you're right and the code should be in here. I 
think we might need to contact the author. 


---

Reply via email to