Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210022817
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
---
@@ -289,6 +294,107 @@ public void testCreateQueue() throws Exception {
jmsServer.stop();
}
+ @Test
+ public void testCompatibilityWith260() {
+ List<String> transportConfigurations = new ArrayList<>();
+ transportConfigurations.add("tst");
+ ConnectionFactoryConfigurationImpl configuration =
(ConnectionFactoryConfigurationImpl) new ConnectionFactoryConfigurationImpl();
+
configuration.setName("np").setConnectorNames(transportConfigurations);
+
+ ByteBuffer buffer =
ByteBuffer.allocate(configuration.getEncodeSize());
+ ActiveMQBuffer activeMQBuffer = new
ChannelBufferWrapper(Unpooled.wrappedBuffer(buffer));
+ activeMQBuffer.clear();
+ encodeVersion260(activeMQBuffer, configuration);
+ configuration.decode(activeMQBuffer);
+ }
+
+ public void encodeVersion260(final ActiveMQBuffer buffer, final
ConnectionFactoryConfigurationImpl connectionFactoryConfiguration) {
--- End diff --
@michaelandrepearce merged... removed your test.. added mine.. take a look
please.
---
