Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210198098
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -640,7 +640,7 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
- enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: null;
+ enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: ActiveMQClient.DEFAULT_ENABLE_1X_PREFIXES;
--- End diff --
Btw, there was an ErrorProne warning for this,
```
[17:16:53][Step 3/3]
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java:643:
error: [NullTernary] This conditional expression may evaluate to null, which
will result in an NPE when the result is unboxed.
[17:16:53][Step 3/3] enable1xPrefixes = buffer.readableBytes() > 0 ?
buffer.readBoolean() : null;
[17:16:53][Step 3/3] ^
[17:16:53][Step 3/3] (see http://errorprone.info/bugpattern/NullTernary)
```
---
