Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211409599
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java
 ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.activemq.artemis.utils;
    +
    +import java.net.URL;
    +import java.util.Properties;
    +
    +import org.jboss.logging.Logger;
    +
    +public final class ArtemisSystemProperties {
    +
    --- End diff --
    
    This class is about defaults... The default coming from a system property.
    
    There's no way around a System property. users coded for older servers will 
need to be switched without changes.
    
    
    The idea of this class is to use a file on the classLoader.
    
    This is mainly for wildfly. In Wildfly they have set the entire VM to use 
older properties. ActiveMQJMSClient should be deprecated... as of now I don't 
see a way we could fix this without System properties.


---

Reply via email to