Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211410036
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java
 ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.activemq.artemis.utils;
    +
    +import java.net.URL;
    +import java.util.Properties;
    +
    +import org.jboss.logging.Logger;
    +
    +public final class ArtemisSystemProperties {
    +
    --- End diff --
    
    BTW: Two CFs can still have different settings.. on the CF this is just 
altering the default. You can still switch independently on the CF. The default 
now comes from a system property instead of a constant variable.
    
    
    As of on the ActiveMQJMSClient, there's no way to alter the semantic 
without a system property. But users shouldn't be encouraged to use that class 
anyways. I'm considering to set it as deprecated.


---

Reply via email to