Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2250#discussion_r220699668
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
---
@@ -1796,15 +1826,15 @@ private synchronized JournalLoadInformation
load(final LoaderCallback loadManage
private void checkID(final long id) {
if (id > maxID.longValue()) {
- maxID.set(id);
+ maxID.lazySet(id);
--- End diff --
After just dealing with a bunch of concurrency issues (bit worried) how
sure is it we def have only single thread at this point with the callbacks,
e.g. how safe is it to switch these to lazySet from set?
---
