Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2250#discussion_r227024184
--- Diff:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java
---
@@ -417,6 +418,18 @@ public synchronized void writeDirect(final ByteBuffer
bytes, final boolean sync,
}
+ @Override
+ public synchronized void blockingWriteDirect(ByteBuffer bytes,
--- End diff --
do you really need synchronized here? this is synchronizing the factory.
---
