Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r232560925
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -318,6 +320,33 @@ public synchronized boolean containsProperty(final
SimpleString key) {
}
}
+ public synchronized boolean
cleanupInternalProperties(Predicate<SimpleString> propertyNamePredicate) {
+ if (!internalProperties) {
--- End diff --
I agree: in that case I would move the other `Message`ish things outside
`TypedProperties`.
I was hoping for a less impactfull change TBH, but you really got a point
about this. Let me check if I can perform a surgical removal to make the code
simpler and cleaner :+1:
---
