Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r233490350
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -52,6 +52,62 @@
* consumers */
public class CoreMessage extends RefCountMessage implements ICoreMessage {
+ private static final class CoreTypedProperties extends TypedProperties {
--- End diff --
is this really needed, the way i see it, looking through the usage, these
internal properties, are a bit like the extra properties that exist and
introduced on AMQPMessage, e.g. theyre bits added onto the message but not part
of the core message, could there just be two fields of type TypeProperties in
core message, one (existing) for normal properties, and another for Internal
Properties, which are these things, that then would make cleaning up / not
forwarding on far easier, as then simply you clear them.
---
