[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2427#discussion_r234697388
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
 ---
    @@ -578,34 +567,41 @@ public CoreMessage setUserID(UUID userID) {
        /**
         * I am keeping this synchronized as the decode of the Properties is 
lazy
         */
    -   protected TypedProperties checkProperties() {
    +   protected final TypedProperties getOrCreateProperties() {
    --- End diff --
    
    Just name this getProperties. The name otherwise is too confusing with your 
extracted method


---