Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r234926580
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -578,34 +567,41 @@ public CoreMessage setUserID(UUID userID) {
/**
* I am keeping this synchronized as the decode of the Properties is
lazy
*/
- protected TypedProperties checkProperties() {
+ protected final TypedProperties getOrCreateProperties() {
--- End diff --
All it does it invoke / delegate this method, as such if anything i see
naming CoreMessage.getProperties cleaner. And there is no need to change it
from final, simply you remove the impl in ClientMessageInternalImpl as it would
just inherit.
```
public TypedProperties getProperties() {
return this.checkProperties();
}
```
---
