franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456175930 > > @michaelandrepearce I have checked that is not less optimized because the original version was failing to find the prefixed properties to remove ie was looping every property with a slower method > > Reply, is there a test proving that? Im very suprised, as i can see that the internal flag when debugging master is being set correctly if i set one of those two headers, and i can see it only goes into iterating if it has been set. So if they arent set no iterating occurs. > > Agree the iterating isnt optimal, but it ONLY iterates if that flag was true, so if not true, it doesnt even iterate at all. > > @michaelandrepearce I have checked that is not less optimized because the original version was failing to find the prefixed properties to remove ie was looping every property with a slower method > > Reply, is there a test proving that? Im very suprised, as i can see that the internal flag when debugging master is being set correctly if i set one of those two headers, and i can see it only goes into iterating if it has been set. So if they arent set no iterating occurs. > > Agree the iterating isnt optimal, but it ONLY iterates if that flag was true, so if not true, it doesnt even iterate at all. The problem is when those properties are not set and it will iterate; there is a problem with false positive in the tests I've done some time ago. I can write a new test, but after checking the flamegraphs I was getting very high CPU usage on that iteration when my messages weren't having using "internal properties" at all...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
