franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456292898 > Re the check its no different than before The original check was more generic so that's a great change (in better), because now (your PR) there are no more false positive :) That's why I was pushing to test real message exchange: unit tests were not covering false positive that were happening on real use case. I like your pr so I'm going to merge it, thanks :) This pr pr is not just about optimizations but is really ironing from many pov the original version , especially with concurrent behaviours, wdyt?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
